Create Profile Encoder to JSONify BaseColumnProfiler #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijavis
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
ksneab7
reviewed
Mar 7, 2023
| class ProfileEncoder(json.JSONEncoder): | ||
| """JSONify profiler objects and it subclasses and contents.""" | ||
|
|
||
| def default(self, o): |
There was a problem hiding this comment.
I would change o to be obj this is a little more readable IMO
| import os | ||
| import unittest | ||
| from collections import defaultdict | ||
|
|
||
| pass |
There was a problem hiding this comment.
for what are these pass?
auto-merge was automatically disabled
March 7, 2023 17:21
Head branch was pushed to by a user without write access
ksneab7
approved these changes
Mar 7, 2023
taylorfturner
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.