Encode order column #772
Merged
Encode order column #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijavis
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
approved these changes
Mar 20, 2023
JGSweets
previously requested changes
Mar 20, 2023
kshitijavis
force-pushed
the
encode-order-column
branch
from
a2a3c0b
to
3db5836
Compare
JGSweets
reviewed
Mar 21, 2023
| @@ -89,3 +89,51 @@ def test_encode_categorical_column_profiler_after_update(self): | |||
| ) | |||
|
|
|||
| self.assertEqual(serialized, expected) | |||
|
|
|||
There was a problem hiding this comment.
Thinking long term, would it be better to put the profile specific tests with each profiler's tests instead?
There was a problem hiding this comment.
I like having the tests match the file structure so yeah I second this for sure!
ksneab7
previously approved these changes
Mar 21, 2023
auto-merge was automatically disabled
March 21, 2023 16:38
Head branch was pushed to by a user without write access
JGSweets
approved these changes
Mar 21, 2023
taylorfturner
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on previous PR https://github.com/capitalone/DataProfiler/pull/770