Encode int column #780
Merged
Encode int column #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijavis
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
dataprofiler/tests/profilers/test_numeric_stats_mixin_profile.py
Outdated
Show resolved
Hide resolved
| "sturges", | ||
| "sqrt", | ||
| ] | ||
| expected_min_histogram_bin = 1000 |
There was a problem hiding this comment.
were you having issue cutting this down from 1000? Or decide to keep it at 1000?
| def test_json_encode(self): | ||
| self.maxDiff = None | ||
|
|
||
| mixin = NumericStatsMixin() |
Comment on lines
1183
to
1185
| options = IntOptions() | ||
| options.histogram_and_quantiles.bin_count_or_method = 5 | ||
| profiler = IntColumn("0", options) |
There was a problem hiding this comment.
nice! only nit pick suggestion would be
Suggested change
| options = IntOptions() | |
| options.histogram_and_quantiles.bin_count_or_method = 5 | |
| profiler = IntColumn("0", options) | |
| int_options = IntOptions() | |
| int_options.histogram_and_quantiles.bin_count_or_method = 5 | |
| profiler = IntColumn("0", options=int_options) |
JGSweets
reviewed
Apr 13, 2023
| @@ -1,3 +1,4 @@ | |||
| import json | |||
There was a problem hiding this comment.
When the other PR gets merged, this can get updated and we won't have this code in this one.
auto-merge was automatically disabled
April 14, 2023 17:45
Head branch was pushed to by a user without write access
kshitijavis
force-pushed
the
encode_int_column
branch
from
f23ee19
to
11051ad
Compare
JGSweets
previously approved these changes
Apr 14, 2023
auto-merge was automatically disabled
April 14, 2023 18:48
Head branch was pushed to by a user without write access
kshitijavis
force-pushed
the
encode_int_column
branch
from
7b6b6b8
to
d6fe67e
Compare
auto-merge was automatically disabled
April 17, 2023 21:32
Head branch was pushed to by a user without write access
ksneab7
reviewed
Apr 18, 2023
| @@ -25,7 +25,7 @@ def is_in_range(x: float | int, config: dict) -> bool: | |||
| raise TypeError("Value is not a float") | |||
|
|
|||
|
|
|||
| def is_in_list(x: str, config: dict) -> bool: | |||
| def is_in_list(x: str | int | float, config: dict) -> bool: | |||
| """ | |||
| Check to see x is in the config list. | |||
|
|
|||
There was a problem hiding this comment.
make sure to change the docstring with the type updates as well
kshitijavis
force-pushed
the
encode_int_column
branch
from
279077f
to
5aa8f3b
Compare
ksneab7
approved these changes
Apr 18, 2023
JGSweets
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.