Space analysis dataset sampling addition #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksneab7
requested review from
JGSweets,
taylorfturner,
micdavis and
tyfarnan
as code owners
ksneab7
force-pushed
the
introduce_sampling_to_space_analysis
branch
from
04e3c2c
to
a37811f
Compare
ksneab7
force-pushed
the
introduce_sampling_to_space_analysis
branch
from
87301b4
to
4cee19d
Compare
taylorfturner
approved these changes
Apr 20, 2023
taylorfturner
added
the
Refactor
JGSweets
reviewed
Apr 20, 2023
Comment on lines
-163
to
+150
| "column": profiler.times, | ||
| "column": compiler_times, |
There was a problem hiding this comment.
this is just the ui confusing +/- s right? it seems it is the same code just shifted.
There was a problem hiding this comment.
Yeah I didnt change any of the json output so this should not be an actual change just a shift
ksneab7
commented
Apr 20, 2023
| "name": profile.name, | ||
| "sample_size": sample_size, | ||
| "total_time": total_time, | ||
| "column": compiler_times, |
There was a problem hiding this comment.
@JGSweets you can find the shift is from this line
tyfarnan
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and generation of flame graph script