Remove unnecessary cast() in graph_data.py #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junholee6a
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
|
once #800 is merge, we will move to this one to update branch, review, and merge @junholee6a |
JGSweets
approved these changes
Apr 27, 2023
ksneab7
approved these changes
Apr 27, 2023
Removing this cast() does not cause a mypy error. By the time this line is reached, the type of self.input_file_path is builtins.str. This is because the assert statement at line 196, earlier in the function, removes the None type from self.input_file_path. Therefore this cast() doesn't do anything.
auto-merge was automatically disabled
April 27, 2023 16:03
Head branch was pushed to by a user without write access
junholee6a
force-pushed
the
remove-cast-4
branch
from
6949230
to
4433545
Compare
|
okay @junholee6a read for an update branch on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #717
Removing this
cast()does not cause a mypy error.By the time this line is reached, the type of
self.input_file_pathisbuiltins.str. This is because theassertstatement at line 196, earlier in the function, removes theNonetype fromself.input_file_path. Therefore thiscast()doesn't do anything.