Json Decoder Code Cleanup #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
micdavis
commented
May 9, 2023
•
micdavis
commented
- cleaned up json decoder code
micdavis
requested review from
JGSweets,
ksneab7,
taylorfturner and
tyfarnan
as code owners
JGSweets
reviewed
May 9, 2023
| profiles = {CategoricalColumn.__name__: CategoricalColumn} | ||
| profiles = { | ||
| CategoricalColumn.__name__: CategoricalColumn, | ||
| BaseColumnProfiler.__name__: BaseColumnProfiler, |
There was a problem hiding this comment.
I think we need to have a bigger discussion, but I'm not sure it is appropriate to decode an abstract class. I'm concerned this could cause bugs / problems if it tries to initialize an abstract class.
There was a problem hiding this comment.
If we instead list all the non-abstract classes here, will it be able to load all of them?
JGSweets
reviewed
May 9, 2023
|
|
||
| profile_class = profiles.get(class_name) | ||
| if profile_class is None: | ||
| raise ValueError(f"Invalid profiler class {class_name} " f"failed to load.") | ||
| else: | ||
| return profile_class(None) |
There was a problem hiding this comment.
We can remove the else here and move the return over an indent. Raising above would fail otherwise.
JGSweets
approved these changes
May 10, 2023
taylorfturner
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.