added new options to docs #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksneab7
changed the title
JGSweets
reviewed
May 22, 2023
| @@ -757,6 +760,7 @@ Below is an breakdown of all the options. | |||
| the default labeler | |||
| * max_sample_size - (Int) The max number of samples for the data | |||
| labeler | |||
| * **row_statistics** - (Boolean) Option to enable/disable row statistics calculations | |||
There was a problem hiding this comment.
does this tabbing need to be fixed?
There was a problem hiding this comment.
+1 one indentation... I would think this shouldn't go in the data_labeler section of options, no?
There was a problem hiding this comment.
Its part of structured options so I put it in this section
There was a problem hiding this comment.
Fixiing indentation
taylorfturner
requested changes
May 22, 2023
| @@ -757,6 +760,7 @@ Below is an breakdown of all the options. | |||
| the default labeler | |||
| * max_sample_size - (Int) The max number of samples for the data | |||
| labeler | |||
| * **row_statistics** - (Boolean) Option to enable/disable row statistics calculations | |||
There was a problem hiding this comment.
+1 one indentation... I would think this shouldn't go in the data_labeler section of options, no?
|
@ksneab7 also would recommend PRing from your fork's Also I think this would be a merge to |
JGSweets
merged commit b253aac
into
capitalone:pages/memory-optimization
2 checks passed
micdavis
pushed a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.