This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Jenkins/code quality #1368
Merged
Jenkins/code quality #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doh! forgot to set the extra data so the results appear in the UI. I'll add this over the weekend. |
|
please rebase |
|
okay. I'll do that soon. |
|
done |
|
shall I close this PR? Any chance of it getting merged? |
|
@stevegal Will look into this one next week. All contributions are welcome. Thanks. |
|
@stevegal Thanks for the contribution. To maintain the naming convention, do you mind changing the directory name from to The artifactId in the pom is correct and needs to be |
satishc1
reviewed
Jul 18, 2017
| Copy this file to your server and launch it using : | ||
| ``` | ||
| java -JAR jenkins-codequlaity-collector.jar | ||
| ``` |
satishc1
reviewed
Jul 18, 2017
| @@ -0,0 +1,18 @@ | |||
|
|
|||
| FROM docker.io/java:openjdk-8-jdk | |||
There was a problem hiding this comment.
@stevegal Please change to
FROM docker.io/openjdk:8-jre
satishc1
reviewed
Jul 18, 2017
| mkdir /hygieia | ||
|
|
||
| COPY *.jar /hygieia/ | ||
| COPY bamboo-build-properties-builder.sh /hygieia/ |
There was a problem hiding this comment.
@stevegal Please change to reflect the correct builder.sh
COPY jenkins-codequality-properties-builder.sh /hygieia/
satishc1
reviewed
Jul 18, 2017
pom.xml
Outdated
| @@ -172,6 +186,7 @@ | |||
| <module>collectors/build/bamboo</module> | |||
| <module>collectors/build/jenkins</module> | |||
| <module>collectors/build/jenkins-cucumber</module> | |||
| <module>collectors/build/jenkins-codequality-collector</module> | |||
| <module>collectors/build/sonar</module> | |||
There was a problem hiding this comment.
@stevegal Change to
<module>collectors/build/jenkins-codequality</module>
satishc1
reviewed
Jul 18, 2017
pom.xml
Outdated
| @@ -215,6 +230,7 @@ | |||
| <module>collectors/build/bamboo</module> | |||
| <module>collectors/build/jenkins</module> | |||
| <module>collectors/build/jenkins-cucumber</module> | |||
| <module>collectors/build/jenkins-codequality-collector</module> | |||
There was a problem hiding this comment.
@stevegal Change to
<module>collectors/build/jenkins-codequality</module>
Correct Dockerfile ensure generated properties file is used in docker
…gieia into jenkins/code_quality
|
@satishc1 thanks for the comments. I was away from my keyboard for a few days, hence the delay in updating. |
|
@stevegal No problem. Thanks for the contribution. Will try to merge it this week. |
|
@tabladrum LGTM |
stevegal
added a commit
to stevegal/Hygieia
that referenced
this pull request
Sep 8, 2017
* starting jenkins code quality plugin to gather statistics from junit reporter directly * start of jenkins collector and analyser * started cleanup of old jobs removed from configuration * WIP * added JunitXmlReport and updated the CodeQualityMetricsConverter * basic jenkins client * refined the code quality metric * http jenkins client with basic auth * springify the beans * ensure jobs have nice display names and have the collector id * kinda working first pass * moce logic to do with job storing into a separate service to help complexity * make code qulaity data service more robust * get findbugs visitor pattern in place * update findbugs visitor prelim * findbugs & junit working with single pattern * get timestamp from jenkins job * update to latest snapshot version * update collector to work with github orgs * add in missing banner + log settings * add project readme * start of code coverage from jacoco * collect jacaco xml report * fixes * forgot to commit test * pmd and checkstyle added * update README with jacoco example * correct checkstyle default pattern in README * Update pom.xml * minimum changes to allow porject to build * handle no errors available in checkstyle * Start of JenkinsPublish Build Step move common model (junit/pmd/findbugs/checkstyle/jacoco) into the core module start step definition * add in jelly config for step * test marker to pick up later * minimum changes to allow project to build * try mvn build in quiet mode * start of plugin step run functionality * marker for next stage of dev * add in pmd/findbugs/checkstyle/jacoco support * working pipeline plugin * Update mongosrc.js * publish build data and link code quality to it * Update code-quality collector name in line with suggestion Correct Dockerfile ensure generated properties file is used in docker
Praveen-chaganti
pushed a commit
to Praveen-chaganti/Hygieia
that referenced
this pull request
Oct 19, 2018
* starting jenkins code quality plugin to gather statistics from junit reporter directly * start of jenkins collector and analyser * started cleanup of old jobs removed from configuration * WIP * added JunitXmlReport and updated the CodeQualityMetricsConverter * basic jenkins client * refined the code quality metric * http jenkins client with basic auth * springify the beans * ensure jobs have nice display names and have the collector id * kinda working first pass * moce logic to do with job storing into a separate service to help complexity * make code qulaity data service more robust * get findbugs visitor pattern in place * update findbugs visitor prelim * findbugs & junit working with single pattern * get timestamp from jenkins job * update to latest snapshot version * update collector to work with github orgs * add in missing banner + log settings * add project readme * start of code coverage from jacoco * collect jacaco xml report * fixes * forgot to commit test * pmd and checkstyle added * update README with jacoco example * correct checkstyle default pattern in README * Update pom.xml * minimum changes to allow porject to build * handle no errors available in checkstyle * Start of JenkinsPublish Build Step move common model (junit/pmd/findbugs/checkstyle/jacoco) into the core module start step definition * add in jelly config for step * test marker to pick up later * minimum changes to allow project to build * try mvn build in quiet mode * start of plugin step run functionality * marker for next stage of dev * add in pmd/findbugs/checkstyle/jacoco support * working pipeline plugin * Update mongosrc.js * publish build data and link code quality to it * Update code-quality collector name in line with suggestion Correct Dockerfile ensure generated properties file is used in docker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a collector for junit/pmd/findbugs/checkstyle for those who don't use sonar.