Issues/1345 - EB/EFS on/offhours tagging workaround #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B/EFS on/offhours tag value constraints
kapilt
reviewed
Jul 19, 2017
c7n/filters/offhours.py
Outdated
| stalk/latest/dg/using-features.tagging.html>`_ and `EFS <http://docs.aws.amazon. | ||
| com/efs/latest/ug/API_Tag.html>`_. In particular, these services do not allow | ||
| parenthesis, square brackets, commas, or semicolons, or empty tag values. This | ||
| proves to be problematic with the tag-based schedule configuration describe |
|
Typo fixed. Sorry about that, but good catch. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #1345, where we can't use on/offhours with resources in Elastic Beanstalk or in CF stacks that include EFS Volumes, as those services have tag value constraints that don't allow empty tag values, and don't allow many of the characters used in the tag-based scheduling.
onorfoobarhas the same operation as an empty tag value).