Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service limits action - formatting the request #1526

Merged
merged 25 commits into from
Sep 19, 2017

Conversation

gitchristo
Copy link
Contributor

Modifications:

  1. Create a single case for each main service type while including all the sub service types in the same case
  2. Include the current limit, current usage and new requested limit in the created request.
  3. Replace the limit increase percentage with a quantifiable amount to be increased, depending on the current limit
  4. Included the account ID # in the subject (currently when AWS responds, the emails will not carry the account name, making it difficult to locate the account in order to log in and close the relevant case once resolved).

e.g. Case
subject--- [Account:134135245324]Raise the following limit(s) of EBS in us-east-1
Please raise the below account limit(s);

Increase Active volumes by 1000 in us-east-1
Current Limit: 5000
Current Usage: 250
Set New Limit to: 6000

Increase Provisioned IOPS by 20000 in us-east-1
Current Limit: 100000
Current Usage: 21000
Set New Limit to: 120000

@gitchristo gitchristo changed the title Service limits action - formatting the request WIP - Service limits action - formatting the request Aug 31, 2017
@kapilt
Copy link
Collaborator

kapilt commented Sep 1, 2017

re ci failure you have a doc string issue thats causing a problem

Warning, treated as error:
/home/travis/build/capitalone/cloud-custodian/c7n/resources/account.py:docstring of c7n.resources.account.RequestLimitIncrease:22:Block quote ends without a blank line; unexpected unindent.
make[1]: *** [html] Error 1
make[1]: Leaving directory `/home/travis/build/capitalone/cloud-custodian'
make: *** [sphinx] Error 2
ERROR: InvocationError: '/usr/bin/make sphinx'```

@kapilt
Copy link
Collaborator

kapilt commented Sep 1, 2017

for 2. i think we need a new option for this, we want to maintain backward compatibility, and reusing the percent-increase option as a not a percent is non-intuitive. adding a amount-increase as a delta value or resource-count as an absolute would be better.

@gitchristo
Copy link
Contributor Author

WIP

@gitchristo gitchristo closed this Sep 11, 2017
@gitchristo gitchristo mentioned this pull request Sep 12, 2017
taohungyang and others added 3 commits September 13, 2017 11:14
Suggestion for the fraction number.
Please review and see if you agree with it or if there is any bug
Suggestion for the fraction number processing
@gitchristo gitchristo reopened this Sep 14, 2017
@gitchristo
Copy link
Contributor Author

Added new option to be enable to specify an exact value to be raised (either one of percent-increase or amount-increase can be used in the policy)

@gitchristo gitchristo changed the title WIP - Service limits action - formatting the request Service limits action - formatting the request Sep 14, 2017
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

@kapilt
Copy link
Collaborator

kapilt commented Sep 19, 2017

i almost feel like we want an additional option here, if your creating an account you want to be able to increase to a set number/value.. ie set this value to 2000, but this is probably workable even in that context.

@kapilt kapilt merged commit d47ad74 into cloud-custodian:master Sep 19, 2017
kapilt pushed a commit to kapilt/cloud-custodian that referenced this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants