adding support to filter on 'vpc attribute' #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Dec 25, 2017
c7n/resources/vpc.py
Outdated
|
|
||
| for r in resources: | ||
| hostname = client.describe_vpc_attribute( | ||
| VpcId=r['VpcId'], |
There was a problem hiding this comment.
Ideally only fetch the attribute if it’s being matched on
kapilt
reviewed
Dec 25, 2017
c7n/resources/vpc.py
Outdated
| """Filters VPCs based on their DNS attributes""" | ||
| schema = type_schema( | ||
| 'vpc-attributes', | ||
| EnableDnsHostnames={'type': 'boolean'}, |
There was a problem hiding this comment.
We be generally gone for lower case hyphenated when not letting the user specify arbitrary keys
There was a problem hiding this comment.
gotcha. I had originally used lower case for the parameters but noted a few instances where upper case was used.
|
I also forgot to add in a mock policy in the docstring... |
- corrected parameter case (all lower case) - added example policy in doctstring - added second unittest for single attribute matching
|
i'd suggest we also drop the 'enable' prefix on the attributes. |
- removing 'enabled' prefix from parameters - correcting example policy to make sense with provided filter
- correcting unittest (previously changed parameter syntax)
lamyanba
pushed a commit
to lamyanba/cloud-custodian
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1616 , adding support to filter VPC based on vpc-attribute