Extend has-statement s3 filter to check for full bucket policy definitions in addition to policy names. #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions in addition to policy names.
|
thanks for the pr. i pushed a commit with some minor changes/cleanups. modified the matching logic to be more explicit, (default not match), also switched value in statement[key] to equality check. |
kapilt
approved these changes
Feb 5, 2018
| found = False | ||
| for key, value in required_statement.items(): | ||
| if key in statement and value == statement[key]: | ||
| found = True |
There was a problem hiding this comment.
@kapilt I think the change here is incorrect.
Provided the example policy in the comments above, the logic here says that any one of
key/value pairs in
- Effect: Allow
Action: 's3:*'
Principal: '*'
is sufficient to match the statement rather than all key/value pairs matching.
lamyanba
pushed a commit
to lamyanba/cloud-custodian
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.