Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Matching Rows and Columns in Mismatch Output for Readability. #42

Closed
alegarpa opened this issue Jun 4, 2019 · 9 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@alegarpa
Copy link

alegarpa commented Jun 4, 2019

Currently the csv that's being written out has all the columns written out on a failed comparison making it harder to read with a larger data-set.
This is more of a feature request but the ability to only have columns that didn't match written to the mismatch csv would really help and speed up the QA process on our end.

@fdosani
Copy link
Member

fdosani commented Jun 5, 2019

Thanks for opening this issue @alegarpa
@theianrobertson thoughts on this feature request?
It seems reasonable to me FWIW.

@fdosani fdosani added this to To do in Release 0.7.0 Sep 27, 2019
@fdosani fdosani removed this from To do in Release 0.7.0 Jun 9, 2020
@fdosani fdosani added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 5, 2021
@fdosani
Copy link
Member

fdosani commented Aug 5, 2021

Adding to roadmap and backlog.

@fdosani fdosani added this to To do in v0.7.3 Aug 5, 2021
@azadekhalaj
Copy link
Contributor

@fdosani Hi Faisal. I am wondering if this issue is still existing and if yes, I can work on this issue or not. Thanks.

@fdosani
Copy link
Member

fdosani commented Oct 13, 2022

@fdosani Hi Faisal. I am wondering if this issue is still existing and if yes, I can work on this issue or not. Thanks.

Hey there, I don’t think we have anyone working on this. Happy to take the extra support on this if you want to take a crack at it! Thanks 😊

@azadekhalaj
Copy link
Contributor

@fdosani Awesome! Thank you :)

azadekhalaj pushed a commit to azadekhalaj/datacompy that referenced this issue Oct 14, 2022
… method to control the addition of matching columns to the output.
azadekhalaj pushed a commit to azadekhalaj/datacompy that referenced this issue Oct 14, 2022
… method to control the addition of matching columns to the output.
azadekhalaj added a commit to azadekhalaj/datacompy that referenced this issue Oct 14, 2022
… method to control the addition of matching columns to the output.
azadekhalaj added a commit to azadekhalaj/datacompy that referenced this issue Oct 14, 2022
… method to control the addition of matching columns to the output.
fdosani pushed a commit that referenced this issue Oct 14, 2022
… control the addition of matching columns to the output. (#166)
@fdosani
Copy link
Member

fdosani commented Oct 14, 2022

Fixed in #166

@alegarpa
Copy link
Author

alegarpa commented Jan 4, 2023

I never thanked ya'll for this publicly but @azadekhalaj and @fdosani thank you so much for updating the library! Happy new year!

@fdosani
Copy link
Member

fdosani commented Jan 4, 2023

@alegarpa Happy new year too!

@azadekhalaj
Copy link
Contributor

@alegarpa Your welcome! Happy new year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
v0.7.3
To do
Development

No branches or pull requests

3 participants