Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are failing due to test_decimal_with_joins #47

Closed
fdosani opened this issue Sep 25, 2019 · 1 comment
Closed

tests are failing due to test_decimal_with_joins #47

fdosani opened this issue Sep 25, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@fdosani
Copy link
Member

fdosani commented Sep 25, 2019

Seems like the TravisCI tests are failing. I think this is due to the version of various packages not being pinned. As the packages change and evolve so will testing behaviour.

The following test is failing:

def test_decimal_with_joins():
    df1 = pd.DataFrame([{"a": Decimal("1"), "b": 2}, {"a": Decimal("2"), "b": 2}])
    df2 = pd.DataFrame([{"a": 1, "b": 2}, {"a": 2, "b": 2}])
    with raises(ValueError):
        compare = datacompy.Compare(df1, df2, "a")

I think in the past Pandas might have has different behaviour. Testing with 0.19.0 version of Pandas and Python 3.5 it still seems to NOT throw any error.

@fdosani fdosani added the bug Something isn't working label Sep 25, 2019
@fdosani fdosani self-assigned this Sep 25, 2019
@fdosani
Copy link
Member Author

fdosani commented Sep 25, 2019

Looking back in the issue history we did talk about this, and I guess it was reverted back to pre-0.23.x functionality in 0.24+. Ref: #19

I think removing the raises is the right thing to do. Seems to be a pandas versioning issue/bug.
Pandas Ref: pandas-dev/pandas#21681

fdosani added a commit that referenced this issue Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant