Adding support for SQLite #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ak-gupta I think for the failing tests we can change the dev requirements files to the following: Just set the connectors to be |
fdosani
requested changes
Oct 21, 2019
|
Oh, do I need to increment the version before merging to master? |
No need. I'll take care of that once we are ready to cut a new release. |
|
Ok great, just wanted to make sure! |
jborchma
reviewed
Oct 22, 2019
| @@ -110,7 +110,7 @@ def _disconnect(self): | |||
| else: | |||
| logger.info("No connection to close") | |||
|
|
|||
| def execute(self, sql, commit=True, params=None): | |||
| def execute(self, sql, commit=True, params=()): | |||
There was a problem hiding this comment.
I am curious about this change here. Is this to align with some convention for SQLite?
There was a problem hiding this comment.
Yeah, when I tried to use Database with params=None it didn't work
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I have added support for SQLite as well as an additional feature for Snowflake users. If the user supplies
schemain their credentials,locopy.snowflake.Snowflakewill runUSE SCHEMA {schema}for the user.Fixes #50
Fixes #55