This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Upgrade to RN 0.47.2 #184
Merged
Upgrade to RN 0.47.2 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the version upgrade of react-native-svg is important in order for this to run on android. |
|
@Minishlink Any chance you can test the change for ios? I ran into this problem: facebook/react-native#14935. This will need to be fixed before merging. |
|
@marzolfb Are you talking about the Example app? It seems like the upgrade to 0.46 wasn't done with |
|
Yes. Sorry for not being clear. Thanks for the additional commit. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing a pull request.
Please ensure that you have signed the CLA.
This is backwards compatible.