-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"cl-flet" macros in recent emacsen break yas--fom-set-next-from #330
Conversation
Your issue may be related to my pull request #324. Can you tell me your exact Emacs version so that I can duplicate? |
Hi, GNU Emacs 24.2.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) |
Thanks @rolandwalker for following up on this. I'm afraid I have little time for yasnippet lately and have added https://github.com/capitaomorte/yasnippet#important-note-regarding-bug-reporting. Let's keep this pull request open for followin up on this issue though. |
Ok thanks. Apparently the macro is called |
Yes, But @yyr made a good catch: they are adding So my #324 should be revised anyway, which would cover this. @yyr, I recommend you change every occurrence of the symbol |
@capitaomorte Sorry for not giving enough background while submitting bug. I will follow procedures next time. @rolandwalker Sure I will add. |
@rolandwalker It should really be @yyr no problem, that's just an automated response I built (cause I really have little time for many back and forth emails), and you were the unlucky first to get it. |
So should we change to cl-labels with a compatibility macro for now.? or leave as it is until 24.3 release ? |
I think we should leave this as is until 24.3 release. I'll leave this pull request open though. Feel free to add commits to this pull request (maybe some commits that puts all the compatiblity macros and hacks in Or maybe just leave it be, I've posted the emacs-devel mailing list to get an idea of what they mean to do with this. |
OK, I asked on emacs-devel and the whole conversation in in this thread http://comments.gmane.org/gmane.emacs.devel/151211. This means:
Emacs devels talk of a forward compatibility lib, so maybe @rolandwalker you want to contribute there. |
No description provided.