Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse HTTP headers in web feed discovery function #9

Closed
capjamesg opened this issue Jan 10, 2022 · 1 comment
Closed

Parse HTTP headers in web feed discovery function #9

capjamesg opened this issue Jan 10, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@capjamesg
Copy link
Owner

In draft PR #8, I noted:

I also wonder whether HTTP headers should be included in this function, too. Parsing HTTP headers is not too difficult. I can imagine edge cases where someone may provide a feed as a HTTP header but not as a header.

This is outwith the scope of the PR in which the proposal was made.

The idea is that we should parse parse headers in thediscover_web_page_feeds() function. This will ensure that feeds will be returned for pages who only specify their feeds in a header. While this is an edge case, accounting for this case will make the feed discovery function more robust.

@capjamesg capjamesg added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2022
capjamesg added a commit that referenced this issue Jan 31, 2022
capjamesg added a commit that referenced this issue Feb 4, 2022
Add code snippet examples, add feature in issue #9, add new test cases
@capjamesg
Copy link
Owner Author

This feature has been implemented so I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant