Making type IDs accessible from Rust code #2
Conversation
ghost
mentioned this pull request
| @@ -1286,6 +1320,7 @@ fn generate_node(node_map : &collections::hash_map::HashMap<u64, schema_capnp::n | |||
| Line("use capnp::capability::{ClientHook, FromClientHook, FromServer, Request, ServerHook};".to_string())); | |||
| mod_interior.push(Line("use capnp::capability;".to_string())); | |||
| mod_interior.push(BlankLine); | |||
| mod_interior.push(Line(format!("pub const INTERFACE_ID: u64 = {:#x};", node_id))); | |||
There was a problem hiding this comment.
I feel like this ought to be called TYPE_ID as well. That would be more consistent with the C++ version (see the definition of CAPNP_DECLARE_INTERFACE_HEADER in generated_header_support.h). Do you have a reason to prefer INTERFACE_ID?
There was a problem hiding this comment.
Well I thought INTERFACE_ID would be a little bit more explicit, but I'm not really attached to it ...
|
Looks good! I just have a few nitpicks, as discussed in my other comments. |
|
I went ahead and merged your branch that had the private inner module. Thanks! |
|
Oops, Sorry! Looks like I took too long to do the last fixes! |
|
No worries! I've just merged that commit in too. |
These patches should allow the use of Capn'Proto type ids from Rust code.
For a Capn'Proto struct, it declares a
const TYPE_ID: u64in the module defining the struct, and theReaderandBuilderboth implement theHasTypeIdtrait defining atype_id(_ : Option<Self>)function (no better way to call it before UFCS).For an enum, it only makes the enum implement the
HasTypeIdtrait.For an interface, it declare a
const INTERFACE_ID: u64in the module defining the interface, and the Client implements theHasTypeIdtraitThis pull request requires the HasTypeId trait in the runtime library.