-
-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shutdown was originally written for Conn.Close and included a wait for goroutines to report done, as is appropriate. However, when shutdown was called from one of the manager's goroutines (in case of an abort, etc.), the goroutines would deadlock. Now manager.wait is separated out, and I made Conn.Wait use the manager.wait function. This has the side-effect of making Conn.Wait wait for the goroutines to finish, which is more correct than the old behavior. Fixes #45
- Loading branch information
Showing
2 changed files
with
12 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters