Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group rows do not theme as expected #1738

Closed
ahankinson opened this issue Feb 7, 2013 · 9 comments
Closed

Group rows do not theme as expected #1738

ahankinson opened this issue Feb 7, 2013 · 9 comments

Comments

@ahankinson
Copy link
Contributor

In Aristo 1, Grouped rows in a tableview displayed as highlighted rows before being selected. In Aristo 2, grouped table rows only display as with the highlighted row colour if they are selected.

Aristo1
Aristo 1

Aristo2-noGroup
Aristo 2 (nothing selected in grouped table)

Aristo2-noGroup-regSelected
Aristo 2 (non-Group row in grouped table selected)

Aristo2-noGroup-Selected
Aristo 2 (group row after being selected)

@cappbot
Copy link

cappbot commented Feb 7, 2013

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@ahankinson
Copy link
Contributor Author

-#new
+#acknowledged
+#needs-confirmation
+Theme

@cappbot
Copy link

cappbot commented Feb 12, 2013

Milestone: Someday. Labels: #acknowledged, Theme. What's next? A reviewer should examine this issue.

@Dogild
Copy link
Member

Dogild commented Apr 26, 2013

Do you have an example app ?

There isn't this issue in Test/Manual/TableView/GroupRowTest

@ahankinson
Copy link
Contributor Author

Yes -- I have a version of the "Kitchen Sink" app that I hack away at when I need to figure out how to do something. I've made it available here: https://github.com/ahankinson/Cappuccino-Kitchen-Sink. There is a tableview in that app that, in theory, sets the group row for that table. See https://github.com/ahankinson/Cappuccino-Kitchen-Sink/blob/master/AppController.j#L491

I can also confirm that it's not a problem in the GroupRowTest, so it may be a problem with how I have my app set up.

@Dogild
Copy link
Member

Dogild commented Apr 26, 2013

I didn't find any bugs.

Careful with the app. The first tableView don't use the same delegate/datasource as the second. And then, the second tableView is not set to usesAlternatingRowBackgroundColors: (just the font will change for a groupRow without this param). 

@daboe01
Copy link
Contributor

daboe01 commented Jul 28, 2014

i don't see the issue.
it looks like the issue is resolved.
+#works-for-me

@cappbot
Copy link

cappbot commented Jul 28, 2014

Milestone: Someday. Labels: #works-for-me, Theme. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

@cappbot cappbot closed this as completed Jul 28, 2014
@cappbot
Copy link

cappbot commented Jul 28, 2014

Milestone: Someday. Labels: #works-for-me, Theme. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants