CPSplitView doesn't honor splitView:constrainMinCoordinate:ofSubviewAt: when resizing window

[cappuccino]

If I have the following method in a CPSplitView delegate:

@@@

• (int)splitView:(CPSplitView)splitView constrainMinCoordinate:(int)minCoord ofSubviewAt:(int)index
  {
  if (index == 0) {
  return 200;
  }
  else {
  return minCoord;
  }
  }
  @@@

it correctly keeps the subview at index 0 from ever being less than 200 pixels wide when moving the splitter around.

But if I resize the window and make the window smaller, the subview does get resized with a width less than 200 pixels...

I added a log message to the above method to check whether it ever gets called. When resizing the window, the method never gets called. It gets called plenty when moving the splitter.

original LH ticket

This ticket has 1 attachment(s).

[cappuccino]

CPSplitView doesn’t honor splitView:constrainMinCoordinate:ofSubviewAt: when resizing window

The docs on Apple’s page say the following:

This method is invoked before the NSSplitView begins tracking the cursor to position a divider. You may further constrain the limits that have been already set, but you cannot extend the divider limits. proposedMin is specified in the NSSplitView’s flipped coordinate system. If the split bars are horizontal (views are one on top of the other), proposedMin is the top limit. If the split bars are vertical (views are side by side), proposedMin is the left limit. The initial value of proposedMin is the top (or left side) of the subview before the divider. offset specifies the divider the user is moving, with the first divider being 0 and going up from top to bottom (or left to right).

So it sounds like it should only be called during repositioning of the divider. Could you possibly do a test against Cocoa to see whether this is actually the case?

by Francisco Tolmasky

[cappuccino]

CPSplitView doesn’t honor splitView:constrainMinCoordinate:ofSubviewAt: when resizing window

Ok, I wrote a little cocoa app and this method does get called when the window is resized as well as when the divider is repositioned.

I attached the project if you care to see for yourself...

by Patrick Crosby

[cappuccino]

CPSplitView doesn’t honor splitView:constrainMinCoordinate:ofSubviewAt: when resizing window

Cool, I’ll try to fix this tomorrow then

by Francisco Tolmasky

[cappuccino]

CPSplitView doesn’t honor splitView:constrainMinCoordinate:ofSubviewAt: when resizing window

This hasn’t been fixed in 0.7b yet.
Here is a test case :
http://gist.github.com/83999

by Thomas Balthazar

[stevegeek]

http://github.com/stevegeek/CappuccinoBugs/tree/master/i0041/ I have commited the test here, and I do not see the problem anymore

[dbrajkovic]

I do not believe this is a bug. Cocoa's NSSplitView performs in the exact same manner (unfortunately).
I think the proper solution is the delegate method splitViewDidResizeSubviews:
For example, in my app, my constrained, min, and max positions are all 151, so I implemented the following delegate method.
-(void) splitViewDidResizeSubviews:(CPNotification)notification { [splitView setPosition:151 ofDividerAtIndex:0]; }
Obviously, you can change this to test the size of the resized subviews and if below a minimum or greater than a maximum, set the position of the divider accordingly. In Cocoa, I have found at least one framework that subclassed NSSplitView to handle this with attributes instead of a delegate. See http://brandonwalkin.com/bwtoolkit/ The source code is included.

[aparajita]

This still happens in Cappuccino, I need to check if it happens in Cocoa.

[aparajita]

The behavior you are seeing is correct according to Cocoa. The way to do what you want is covered here:

http://www.cocoabuilder.com/archive/cocoa/77994-restricting-an-nssplitview-when-resizing-window.html#77996

The -adjustSubviews method has been added to CPSplitView.