Error messages if dataset validation fails (#11)

* Error messages if dataset validation fails
capreolus-ir · Jun 7, 2021 · f3180e7 · f3180e7
1 parent 92c3034
commit f3180e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/diffir/__init__.py b/diffir/__init__.py
@@ -1,4 +1,4 @@
-__version__ = "0.1.0"
+__version__ = "0.2.0"
 
 from diffir.weight import Weight
 from diffir.weight.custom import CustomWeight

diff --git a/diffir/run.py b/diffir/run.py
@@ -378,9 +378,8 @@ def json(self, run_1_fn, run_2_fn=None):
         run_2 = load_trec_run(run_2_fn) if run_2_fn is not None else None
 
         dataset = ir_datasets.load(self.dataset)
-        assert dataset.has_docs()
-        # TODO: handle the case without qrels
-        assert dataset.has_queries()
+        assert dataset.has_docs(), "dataset has no documents; maybe you're missing a partition like '/trec-dl-2020'"
+        assert dataset.has_queries(), "dataset has no queries; maybe you're missing a partition like '/trec-dl-2020'"
         diff_queries, qid2diff, metric_name, qid2qrelscores = self.measure.query_differences(run_1, run_2, dataset=dataset)
         # _logger.info(diff_queries)
         diff_query_objects = self.create_query_objects(