#960@trivial: Fix introduced bug in ElementUtility.appendChild() and …

…ElementUtility.insertBefore().
capricorn86 · Aug 22, 2023 · 0b31097 · 0b31097
1 parent 3b120c0
commit 0b31097
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/happy-dom/src/nodes/element/ElementUtility.ts b/packages/happy-dom/src/nodes/element/ElementUtility.ts
@@ -53,8 +53,9 @@ export default class ElementUtility {
 							if (attribute) {
 								parentNodeChildren._removeNamedItem(<IHTMLElement>node, attribute.value);
 							}
-							parentNodeChildren.splice(index, 1);
 						}
+
+						parentNodeChildren.splice(index, 1);
 					}
 				}
 			}
@@ -149,6 +150,8 @@ export default class ElementUtility {
 								parentNodeChildren._removeNamedItem(<IHTMLElement>newNode, attribute.value);
 							}
 						}
+
+						parentNodeChildren.splice(index, 1);
 					}
 				}
 			}

diff --git a/packages/happy-dom/test/nodes/element/Element.test.ts b/packages/happy-dom/test/nodes/element/Element.test.ts
@@ -1130,7 +1130,7 @@ describe('Element', () => {
 			const div1 = document.createElement('div');
 			div1.classList.add('someClassName');
 			div1.innerHTML = 'div1';
-			container.after(div1);
+			container?.after(div1);
 			expect(document.body.children.length).toBe(2);
 
 			const div2 = document.createElement('div');