fix: [#1347] LocalStorage.setItem non-string value should to be string (

#1348)
capricorn86 · Mar 23, 2024 · 44dd9ce · 44dd9ce
1 parent b5af02b
commit 44dd9ce
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/happy-dom/src/storage/Storage.ts b/packages/happy-dom/src/storage/Storage.ts
@@ -31,7 +31,7 @@ export default class Storage {
 	 * @param item Item.
 	 */
 	public setItem(name: string, item: string): void {
-		this[name] = item;
+		this[name] = String(item);
 	}
 
 	/**

diff --git a/packages/happy-dom/test/storage/Storage.test.ts b/packages/happy-dom/test/storage/Storage.test.ts
@@ -51,6 +51,16 @@ describe('Storage', () => {
 			expect(storage['key2']).toBe('value2');
 			storage['key1'] = 'value3';
 			expect(storage.getItem('key1')).toBe('value3');
+
+			// @ts-expect-error
+			storage.setItem('key1', 1);
+			expect(storage.getItem('key1')).toBe('1');
+			expect(storage['key1']).toBe('1');
+
+			// @ts-expect-error
+			storage.setItem('key1', {});
+			expect(storage.getItem('key1')).toBe('[object Object]');
+			expect(storage['key1']).toBe('[object Object]');
 		});
 	});