Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer escapes attributes too much #335

Closed
Demivan opened this issue Jan 20, 2022 · 1 comment · Fixed by #336
Closed

Serializer escapes attributes too much #335

Demivan opened this issue Jan 20, 2022 · 1 comment · Fixed by #336

Comments

@Demivan
Copy link
Contributor

Demivan commented Jan 20, 2022 •
edited

I tried using happy-dom with Vitest and when switching from jsdom I got a failing test:

image

image

happy-dom is escaping characters in html attributes that are allowed. There is no need to use encode from he, escape is enough.
Demivan added a commit to Demivan/happy-dom that referenced this issue Jan 20, 2022
@Demivan
capricorn86#335@trivial: Add failing XML serializer test.
68c084f
Demivan added a commit to Demivan/happy-dom that referenced this issue Jan 20, 2022
@Demivan
capricorn86#335@patch: Fix escaping attribute value.
8f61417
Demivan added a commit to Demivan/happy-dom that referenced this issue Jan 20, 2022
@Demivan
capricorn86#335@trivial: Update XML serializer test.
fae1f61
@Demivan Demivan mentioned this issue Jan 20, 2022
Merged
@capricorn86
Copy link
Owner

Thanks for contributing @Demivan! 🙂

Your fix has been released.

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v2.27.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task/335 fix xml serializer Demivan/happy-dom
2 participants
@Demivan @capricorn86