#308@minor: Implement NamedNodeMap and use it for Element.attributes #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
previously approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Thank you for your contribution @jledentu! It looks really nice ⭐
I have made some adjustment, so that the interface looks more like the built in Typescript DOM interface. Unfortunately Typescirpt dosn't handle both [k: string] and other properties and methods at the same time, but it also makes sense in a way and this is how they have done it.
I also added some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR implements the NamedNodeMap interface and makes it available in
Window.Element.attributesnow returns aNamedNodeMap.Closes #308