Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#659@trivial: Make sure MutationObserver target is not null before disconnecting #705

Merged
merged 2 commits into from Jan 30, 2023
Merged

#659@trivial: Make sure MutationObserver target is not null before disconnecting #705

merged 2 commits into from Jan 30, 2023

Conversation

victorwedo
Copy link
Contributor

@victorwedo victorwedo commented Jan 30, 2023 •
edited

No description provided.

@victorwedo victorwedo changed the title #659@trivial: Make sure MutationObserver target is not null before disconnecting #659@trivial: Make sure MutationObserver target is not null before di… Jan 30, 2023
@victorwedo victorwedo marked this pull request as draft January 30, 2023 16:33
@victorwedo victorwedo marked this pull request as ready for review January 30, 2023 16:33
@victorwedo victorwedo changed the title #659@trivial: Make sure MutationObserver target is not null before di… #659@trivial: Make sure MutationObserver target is not null before disconnecting Jan 30, 2023
@victorwedo victorwedo force-pushed the task/659-mutation-observer-disconnect branch from da6fc58 to 25097ec Compare January 30, 2023 16:42
@masteryder
Copy link

lgtm

@anishLearnsToCode
Copy link

needed right away !! 🚀 🚀

capricorn86
capricorn86 reviewed Jan 30, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ⭐

@capricorn86
Copy link
Owner

Thank you for your contribution @victorwedo! 🙂

@capricorn86 capricorn86 merged commit 9bc81a2 into capricorn86:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victorwedo @masteryder @anishLearnsToCode @capricorn86