#709@patch: Properly detect ShadowRoot boundary when constructing composedPath
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sedPath for HTMLAnchorElement.
…ructing `composedPath` for event.
…ot in more places where the host property is used.
capricorn86
approved these changes
Feb 2, 2023
|
Thank you for your contribution @romansp! ⭐ Good that you found this bug 😅 The biggest reason for avoiding checking with I have made a commit which checks with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #709.
Not exactly sure about this
instanceof ShadowRootcheck with an extra import as I couldn't find other similar usages the codebase. Will be happy to update this PR If there's a more desirable pattern.