Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#785@minor: Add document.title. #786

Merged
merged 3 commits into from Feb 25, 2023
Merged

#785@minor: Add document.title. #786

merged 3 commits into from Feb 25, 2023

Conversation

btea
Copy link
Contributor

@btea btea commented Feb 24, 2023 •
edited

close #785

CSchulz
CSchulz approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@CSchulz CSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me.

capricorn86
capricorn86 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟

@capricorn86 capricorn86 merged commit 1814f62 into capricorn86:master Feb 25, 2023
@btea btea deleted the task/785-add-document-title branch February 25, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CSchulz CSchulz CSchulz approved these changes

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

direct write document.title does not work
3 participants
@btea @CSchulz @capricorn86