-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using deploy -d with incorrect password #27
Comments
I don't think this change was intentional. I'll look into it. You can always go back to the previous version via @Hazzard17h was this an intended change? |
Have reverted to
|
Having upgraded to |
@drmrbrewer |
This was an intended change. If you think than must be done the authentication check (token check and ask password if expired), I can add it. |
Personally I'd find it very useful to have the behaviour as per v1... or at least have an option for it, i.e. to allow user interaction in the specific case where the auth token for accessing the caprover server is no longer valid. It enables me to do a quick |
IMHO, to use deploy in a script, the best option is |
According to the docs, |
Please, see updated docs related to the use of CLI, on the readme of this project: all commands accept |
Thanks. Still requires storing passwords in a file, though. Which the CLI v1 |
You could omit the password from config file, and CLI will ask for it if token is expired. But I don't figure why automatic deployment must involve user interaction... |
Why can't this logic apply to
In my case it's not automatic as such... I'm still sat at the terminal but I just run a single command (script) rather than several. Something like:
rather than:
|
Because
You can archive the same result updating the script to call |
Though if you don't want to store passwords in config files then you need to enter the password every time? With the v1 behaviour of the CLI you enter the password once and then only again when the auth token is no longer valid, which may be a looong time... which is very convenient. |
Just seems sensible and logical and helpful to be able to use defaults where available and if a piece of information is not available from defaults then ask for that missing of information. Like for |
No, if you store |
OK. But what is the logic behind asking for it when using |
The point is not As I said before, I could add the authentication check, but |
Asking the user to enter the server password again IMHO is neither breaking things (it was like that in v1 so if anything it is not breaking things) and also it is not a strange behaviour. When using |
Late to the party here. But here is my 2 cents:
In general, I prefer the new behavior as it reduces the chance of wrongfully deploying over another app and other human errors. However, there is one exception to it, and that is the Auth Check. I believe we should add back the auth check to the So my suggestion is to keep things like they are, and just add the authentication check into the flow. Unless this creates a logical mess, I think this is the way to go. @Hazzard17h / @drmrbrewer thoughts? |
My vote is for @githubsaturn as President of the Universe. Back more on topic, I think your summary is pretty much in line with my feelings expressed above (e.g. in the post just above yours) in that the auth check is different to asking for missing defaults as such. So apart from voting for @githubsaturn as POTU, my vote is to re-instate the auth check. |
It's fine for me, add authentication check is quite easy. |
See #33 |
Fixed in #33 and released as 2.1.0 |
Prior to v2 I was able to run
caprover deploy -d
in the knowledge that if the CapRover machine password is no longer valid then I would be prompted for the current password and then the process would continue. Now, it just seems to bail out without a prompt:I prefer the previous behaviour... seems more user friendly just to be able to enter the password rather than having to go through the deploy process again without relying on defaults.
The text was updated successfully, but these errors were encountered: