Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy from GitHub ? #25

Closed
willwade opened this issue Dec 11, 2017 · 7 comments
Closed

Deploy from GitHub ? #25

willwade opened this issue Dec 11, 2017 · 7 comments

Comments

@willwade
Copy link

Is it possible to deploy an app on a GitHub commit? (Like heroku )

@fergyfresh
Copy link

Look up dokku. We could probably modify this to be dokku like (docker-like heroku deploy)

@githubsaturn
Copy link
Collaborator

Dokku is extremely limited to git. Most of the benefits that come with Captain is due to the fact that Captain is not limited to git. It uses git, but it's not limited to git. Things like deploy through web dashboard, one click apps and etc wouldn't have been possible if the architecture was limited to git. The last thing we want is limit ourselves to git like Dokku as that would mean losing everything else.

I guess what you meant was automatic deployment when you push to github, right? The good thing about Captain's generic REST API is that the requested feature is surely possible thorough some sort of adapter. I'll keep this issue open to see how many people actually need this! It requires some non-significant amount of work, so I'll put it in the queue if it's actually a feature that people need 😄

@willwade
Copy link
Author

willwade commented Dec 11, 2017 via email

@fergyfresh
Copy link

@githubsaturn but doesn't Github deployment also significantly limit this to git as well?

A random related question @githubsaturn Captain support event based triggers? Could we trigger a deploy on the Captain server via a Github webhook? Where-ish could I look for event based code? I'll look on my own, but if you get to it before I do any input would be great.

@githubsaturn
Copy link
Collaborator

We wouldn't limit deployment architecture to git. We will have an adapter for github.

Answer to your second question is no. In fact, that's how I'm going to address the github deployment issue. Once implemented, it will work like this:

You push to github
Webhook calls captain saying a new commit is pushed
Captain pulls from github and build

@josegonzalez
Copy link

Just wanted to chime in with a few thoughts:

  • Dokku isn't "limited to git". In fact, we support deploys of bare docker images and tarballs (alongside git). We just so happen to store the current state of your service within a repository on the server if you choose to push code via git.
  • You can support a "push to deploy" type system pretty easily using something like sshcommand. If you wanted to vendor such a thing into captainduckduck, the code is relatively simple and should be able to be ported into nodejs. Once you have a codebase on the server, it's relatively simple for you to extract a tarball and build from there, same as how captainduckduck currently works.

Great project btw, hope your users get excellent value from it :)

One of the Dokku maintainers

@githubsaturn
Copy link
Collaborator

Thanks for your note and clarification. I'll look into sshcommand. Sounds viable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants