-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy from GitHub ? #25
Comments
Look up dokku. We could probably modify this to be dokku like (docker-like heroku deploy) |
Dokku is extremely limited to git. Most of the benefits that come with Captain is due to the fact that Captain is not limited to git. It uses git, but it's not limited to git. Things like deploy through web dashboard, one click apps and etc wouldn't have been possible if the architecture was limited to git. The last thing we want is limit ourselves to git like Dokku as that would mean losing everything else. I guess what you meant was automatic deployment when you push to github, right? The good thing about Captain's generic REST API is that the requested feature is surely possible thorough some sort of adapter. I'll keep this issue open to see how many people actually need this! It requires some non-significant amount of work, so I'll put it in the queue if it's actually a feature that people need 😄 |
Awesome. You are right. I am looking for GitHub deployment. To be clear
it’s because sometimes I’m on my phone or others are on other machines and
they don’t need the entire tool chain to make a change. GitHub deployment
would be awesome.
…On Mon, 11 Dec 2017 at 18:48, Kasra Bigdeli ***@***.***> wrote:
Dokku is extremely limited to git. Most of the benefits that come with
Captain is due to the fact that Captain is not limited to git. It uses git,
but it's not limited to git. Things like deploy through web dashboard, one
click apps and etc wouldn't have been possible if the architecture was
limited to git. The last thing we want is limit ourselves to git like Dokku
as that would mean losing everything else.
I guess what you meant was automatic deployment when you push to github,
right? The good thing about Captain's generic REST API is that the
requested feature is surely possible thorough some sort of adapter. I'll
keep this issue open to see how many people actually need this! It requires
some non-significant amount of work, so I'll put it in the queue if it's
actually a feature that people need 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN_6Al3rIb1N0DfJUDbyRJa_Kp7eIkeks5s_XjhgaJpZM4Q89oa>
.
|
@githubsaturn but doesn't Github deployment also significantly limit this to git as well? A random related question @githubsaturn Captain support event based triggers? Could we trigger a deploy on the Captain server via a Github webhook? Where-ish could I look for event based code? I'll look on my own, but if you get to it before I do any input would be great. |
We wouldn't limit deployment architecture to git. We will have an adapter for github. Answer to your second question is no. In fact, that's how I'm going to address the github deployment issue. Once implemented, it will work like this: You push to github |
Just wanted to chime in with a few thoughts:
Great project btw, hope your users get excellent value from it :) One of the Dokku maintainers |
Thanks for your note and clarification. I'll look into sshcommand. Sounds viable. |
Is it possible to deploy an app on a GitHub commit? (Like heroku )
The text was updated successfully, but these errors were encountered: