Custom username for SSH git deployment #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githubsaturn
approved these changes
Nov 6, 2021
| @@ -10,6 +10,22 @@ import Utils from './Utils' | |||
| const exec = util.promisify(childPross.exec) | |||
|
|
|||
| export default class GitHelper { | |||
| static #SSH_PATH_RE = new RegExp( | |||
There was a problem hiding this comment.
The common practice across the codebase is to use private - rather than # prefix.
It's a minor change, I'll make the change this after merge.
|
If help with regular expressions are needed, I'm an expert and I'll be glad to help in my free time. Just let me know. |
|
@maietta thanks! Feel free to review my changes in the commit linked above and let me know if I did anything dumb :) it's a super naive change, but i read regex the same way i read gibberish 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GIT deployment via SSH throws an authorization error if the SSH username is different from 'git'. This happens because the ssh username is hard coded and not taken from the URL
Fix
Changed the implementation of the URL sanitizer to take the SSH username from the URL.
Implementation
Sanitizing is done in two steps: 1. extract the individual parts from the input URL via a regex (domain, port, repo, ...). 2. construct a new URL by putting the parts together. For the input URL only the domain name and repo name needs to be provided. All other parts of the URL are optional. Default SSH username is 'git' and default port is '22'. '.git' suffix is optional as well.