Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customDomain === rootDomain. #24

Merged
merged 1 commit into from Dec 14, 2017

Conversation

hugojosefson
Copy link
Contributor

(Thank you so much for this project! I found it today via this Medium post: https://medium.com/@kasra85/how-i-cut-my-heroku-cost-by-400-5b9d0220ce13)

It can be quite useful to have the root domain connected to one of the deployed apps. This PR enables that. Because you can not add an app for the apex domain, this won't conflict with any app names created.

(As an aside, in the future, I would also rather see it being possible to add any subdomains/hostnames under the root domain as custom domains. That would then require the 'add app' feature and 'add custom domain to app' features to make sure they don't create conflicting names.)

I have deployed hugojosefson/captainduckduck:apex to Docker Hub based on this branch + rename, tried it, and it works. Here's how to test it on a new clean VPS:

  1. mkdir /captain && docker run -v /var/run/docker.sock:/var/run/docker.sock hugojosefson/captainduckduck:apex
  2. In your DNS, you also need to set up a CNAME or A record for the hostname @, pointing to the same server.
  3. Add any app to your captain.
  4. You should now be able to add the root domain as a custom domain to the app.

@githubsaturn
Copy link
Collaborator

Thanks! This is a good change. The issue has previously been brought up. But since we don't have test coverage, I'll have to go through the code carefully and make sure it doesn't break anything. Stay tuned 👍

@hugojosefson
Copy link
Contributor Author

Great, thanks! :)

@githubsaturn githubsaturn merged commit 09d5185 into caprover:master Dec 14, 2017
@hugojosefson hugojosefson deleted the apex-domain branch December 14, 2017 06:28
@hugojosefson
Copy link
Contributor Author

Thank you @githubsaturn for taking the time.

@githubsaturn
Copy link
Collaborator

No worries. Thank you for contibuting 😄

PS: I'm hoping that I get to bundle a couple of features and release v0.3 in next couple of days. This PR will be present in that release.

@hugojosefson
Copy link
Contributor Author

Cool. Looking forward to it!

EmrysMyrddin pushed a commit to EmrysMyrddin/caprover that referenced this pull request Nov 12, 2019
fix for "PWA HTML5 manifest is default and buggy"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants