Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Thank you so much for this project! I found it today via this Medium post: https://medium.com/@kasra85/how-i-cut-my-heroku-cost-by-400-5b9d0220ce13)
It can be quite useful to have the root domain connected to one of the deployed apps. This PR enables that. Because you can not add an app for the apex domain, this won't conflict with any app names created.
(As an aside, in the future, I would also rather see it being possible to add any subdomains/hostnames under the root domain as custom domains. That would then require the 'add app' feature and 'add custom domain to app' features to make sure they don't create conflicting names.)
I have deployed
hugojosefson/captainduckduck:apex
to Docker Hub based on this branch + rename, tried it, and it works. Here's how to test it on a new clean VPS:mkdir /captain && docker run -v /var/run/docker.sock:/var/run/docker.sock hugojosefson/captainduckduck:apex
@
, pointing to the same server.