Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rethinkdb #20

Closed
githubsaturn opened this issue Feb 2, 2019 · 3 comments
Closed

Suggestion: rethinkdb #20

githubsaturn opened this issue Feb 2, 2019 · 3 comments

Comments

@githubsaturn
Copy link
Collaborator

https://www.rethinkdb.com/

@m0xx
Copy link

m0xx commented Feb 2, 2019

Hi, thanks for this project its awesome!

I could try to put together a PR, but I would like to know how can I test it?

@githubsaturn
Copy link
Collaborator Author

You would have to run dev environment: https://github.com/caprover/caprover/blob/master/CONTRIBUTING.md#running-dev-environment

Or you can wait until we add the functionality to add custom one app clicks to frontend. In about a month.

Having said that, RethinkDB docker seems rather simple, just copy and paste MongoDB file and edit it.
https://github.com/caprover/one-click-apps/blob/master/public/v1/apps/mongodb.json

It just needs some minor changes. RethinkDB does not require any env vars. Therefore, that element will be an empty array. Just create a PR and we'll merge it. 👍

If there is a problem with it, we can always fix it. Since One Click Apps are fetched dynamically from this repository, it doesn't even require an update of CapRover.

@githubsaturn
Copy link
Collaborator Author

Update: the testing capability is added to CapRover v1.2.0 which will be released soon. This is the flow:
https://github.com/caprover/one-click-apps/blob/master/README.md#test-your-one-click-apps

You can use the edge image if you don't want to wait for v1.2.0 release.
https://caprover.com/docs/troubleshooting.html#how-to-use-the-edge-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants