Update config file logic, tests

[mjn0898]

Allowing config file object to be passed into init

[lewismc]

Please address comments
Also, please provide unit tests for the following

• incorrect paths
• garbled, garbage config values
  Thanks

[mjn0898]

The tests are in progress, I just didn't have time to do them today.
I am a bit confused on wanting that logic in the class invocation because you wanted the config file to be passed in as a parameter to the init function, which is why I now pass in a file object which I have to create elsewhere.

[lewismc]

The tests are in progress, I just didn't have time to do them today.

No problem. That's fine. I understand.

I am a bit confused on wanting that logic in the class invocation because you wanted the config file to be passed in as a parameter to the init function, which is why I now pass in a file object which I have to create elsewhere.

Here's what I think would make a sensible API

1. augment the pycoal-mineral CLI options to include an option for a configuration file,
2. augment the MineralClassification init function such that, again, it includes an option for a configuration file. In this case the os.path.join(os.path.dirname(__file__)... logic should reside within MineralClassification __init__ because it may not be called from the example, it may be called from somewhere else e.g. another Python script or pycoal-mineral CLI.

Does that make sense?

[lewismc]

Also, please always label your issues correctly and assign them to the current project. Thanks @mjn0898 good work.

[lewismc]

Thanks for the PR, please see my comments.

[lewismc]

Also, @mjn0898 please address the DeepSource issues. Thanks

[mjn0898]

I fixed the deepsource issues. As for the build errors due to some new tests failing, most of the errors are due to the new algorithm functions not being up to date on this branch.

[lewismc]

@mjn0898 this is looking much better.

As for the build errors due to some new tests failing, most of the errors are due to the new algorithm functions not being up to date on this branch.

Well then please just use the following annotation for the time being

@unittest.skip("reason for skipping")

See the follosing SO post - https://stackoverflow.com/questions/2066508/disable-individual-python-unit-tests-temporarily
Thanks

[lewismc]

Thank you @mjn0898 good work on this branch. Some notes for your consideration

• please always create an issue before you create the pull request. This should describe the scope of the work. Your commit messages should also reflect this scope.
• on commit messages, please see the following - https://chris.beams.io/posts/git-commit/

Thank you, good work

[mjn0898]

Thanks, I will keep that in mind