Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed incorrect MI->ac_idx leading to wrong AArch64 InsnOp access printing #1845

Merged
merged 4 commits into from
Feb 28, 2022
Merged

fixed incorrect MI->ac_idx leading to wrong AArch64 InsnOp access printing #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aafdcac
disable publish to testpypi for now
kabeor Feb 28, 2022
bc4e264
fixed incorrect MI->ac_idx leading to wrong AArch64 InsnOp access pri…
kabeor Feb 28, 2022
eebd845
add ldr operands access issue testcase
kabeor Feb 28, 2022
22b25d4
Merge branch 'capstone-engine:next' into next
kabeor Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/python-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ jobs:
name: artifact
path: dist

- name: Publish distribution 📦 to test PyPI
uses: pypa/gh-action-pypi-publish@master
with:
user: __token__
password: ${{ secrets.testpypi_pass }}
repository_url: https://test.pypi.org/legacy/
# - name: Publish distribution 📦 to test PyPI
# uses: pypa/gh-action-pypi-publish@master
# with:
# user: __token__
# password: ${{ secrets.testpypi_pass }}
# repository_url: https://test.pypi.org/legacy/

- name: Publish distribution 📦 to PyPI
if: ${{ success() }}
Expand Down
1 change: 1 addition & 0 deletions arch/AArch64/AArch64InstPrinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ static void printOperand(MCInst *MI, unsigned OpNum, SStream *O)

access = get_op_access(MI->csh, MCInst_getOpcode(MI), OpNum);
MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].access = access;
MI->ac_idx++;
#endif
MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].type = ARM64_OP_REG;
MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].reg = Reg;
Expand Down
4 changes: 4 additions & 0 deletions suite/cstest/issues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
!# issue 1839 AArch64 Incorrect detailed disassembly of ldr
!# CS_ARCH_ARM64, CS_MODE_ARM, CS_OPT_DETAIL
0x41,0x00,0x40,0xf9 == ldr x1, [x2] ; operands[0].access: WRITE ; operands[1].access: READ

// !# issue 1827 x86-16 lcall 0:0xd
// !# CS_ARCH_X86, CS_MODE_16, CS_OPT_DETAIL
// 0x9a,0x0d,0x00,0x00,0x00 == lcall 0:0xd
Expand Down