-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PowerPC paired-singles support #1898
Conversation
68b668c
to
9f04a0a
Compare
@@ -372,33 +372,32 @@ enum { | |||
PPC_F4RCRegClassID = 6, | |||
PPC_CRRCRegClassID = 7, | |||
PPC_CARRYRCRegClassID = 8, | |||
PPC_CRRC0RegClassID = 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PPC_CRRC0RegClassID
got removed, most likely due to LLVM TableGen version mismatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also causing build warnings
@terorie Cool, that's really great work, thanks for your contribution! Can I merge now? |
@kabeor I am using LLVM 7.0.1 (without patches), which is the wrong version. It seems the correct version uses some LLVM patch that fixes a security vulnerability: #1510 (comment). So therefore I would be cautious not to reintroduce it. Perhaps let's try to move to LLVM 8.0.1 before merging? Hopefully there aren't too many breaking changes. To make the build work under LLVM 7.0.1, I used the following patch. HTM patchFrom c9d1d43410b56a92aa6951c85497d5fe94c6e80b Mon Sep 17 00:00:00 2001
From: Richard Patel <me@terorie.dev>
Date: Sat, 23 Jul 2022 08:38:29 +0200
Subject: [PATCH] htm
---
suite/synctools/tablegen/PPC/PPCInstrHTM.td | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/suite/synctools/tablegen/PPC/PPCInstrHTM.td b/suite/synctools/tablegen/PPC/PPCInstrHTM.td
index f9c4f42b..fa33a7db 100644
--- a/suite/synctools/tablegen/PPC/PPCInstrHTM.td
+++ b/suite/synctools/tablegen/PPC/PPCInstrHTM.td
@@ -22,7 +22,7 @@ def HTM_get_imm : SDNodeXForm<imm, [{
let hasSideEffects = 1, usesCustomInserter = 1 in {
def TCHECK_RET : Pseudo<(outs gprc:$out), (ins), "#TCHECK_RET", []>;
-def TBEGIN_RET : PPCCustomInserterPseudo<(outs gprc:$out), (ins u1imm:$R), "#TBEGIN_RET", []>;
+def TBEGIN_RET : Pseudo<(outs gprc:$out), (ins u1imm:$R), "#TBEGIN_RET", []>;
}
--
2.32.1 (Apple Git-133) |
Ah, I will merge this immediately (after ci test finished). As you see, #1803 and #1831 lost their contributors, so I wonder to know if you would like to continue work on it? |
Adds support for the proprietary paired-singles extension in PowerPC 750CXe (Gekko) and 750CL (Broadway) CPUs.
Add GQR registers(not needed; GQRs are SPRs, which Capstone represents as immediate)psq_l
,psq_lu
,psq_st
,psq_stu
Closes #476