Fix for incorrect register usages in ARM64 MOV/MOVN instructions. #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by issues #1652 and #1591 there were issues in register usages reported by
cstool
(and associated APIs):This PR fixes the issue and adds a unit test.
Like most other register usage issues, the problem was
arch/AArch64/AArch64MappingInsnOp.inc
and it would be better to fix the script that was used to generate it, but it's sadly not committed as part of Capstone.