Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In capstone 5.0_rc3 the test
test_iter
fails when performing checks for the TriCore architecture.cs_open()
returnsCS_ERR_MODE
(5):The test requests mode
CS_MODE_BIG_ENDIAN | CS_MODE_TRICORE_162
, but TriCore is a little endian architecture. See section 1.1.1 in https://www.infineon.com/dgdl/Infineon-AURIX_TC3xx_Architecture_vol1-UserManual-v01_00-EN.pdf?fileId=5546d46276fb756a01771bc4c2e33bdd. DroppingCS_MODE_BIG_ENDIAN
fixes the error.It seems this kind of error was fixed in d9f13fe, but the test was missed there.