Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TriCore test #2049

Merged
merged 1 commit into from Jun 18, 2023
Merged

Fix TriCore test #2049

merged 1 commit into from Jun 18, 2023

Conversation

hamarituc
Copy link
Contributor

@hamarituc hamarituc commented Jun 17, 2023

In capstone 5.0_rc3 the test test_iter fails when performing checks for the TriCore architecture. cs_open() returns CS_ERR_MODE (5):

$ ./test_iter 
[...]
****************
Platform: TriCore
Failed on cs_open() with error returned: 5

The test requests mode CS_MODE_BIG_ENDIAN | CS_MODE_TRICORE_162, but TriCore is a little endian architecture. See section 1.1.1 in https://www.infineon.com/dgdl/Infineon-AURIX_TC3xx_Architecture_vol1-UserManual-v01_00-EN.pdf?fileId=5546d46276fb756a01771bc4c2e33bdd. Dropping CS_MODE_BIG_ENDIAN fixes the error.

It seems this kind of error was fixed in d9f13fe, but the test was missed there.

@kabeor
Copy link
Member

kabeor commented Jun 18, 2023

Great, Thanks!

@kabeor kabeor merged commit f05e4f6 into capstone-engine:next Jun 18, 2023
7 checks passed
@hamarituc hamarituc deleted the tricore-test branch June 18, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants