Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for msvc static lib, dll build error and warnings #2061

Merged
merged 4 commits into from Jun 25, 2023

Conversation

arkup
Copy link
Contributor

@arkup arkup commented Jun 23, 2023

Building static lib with newer compiler version e.g. <2015 is broken due to unitialize variable error.

Also there seems to be more issues with msvc because building .dll fails too (error LNK2001: unresolved external symbol _insn_find). Include ..\Mapping.c was missing.

Added Tricore files and PreprocessorDefinitions: CAPSTONE_HAS_TRICORE;CRT_SECURE_NO_WARNINGS

@arkup arkup changed the title fix msvc static lib build error due to unitialize variable fix for msvc static lib, dll build error and warnings Jun 24, 2023
@kabeor
Copy link
Member

kabeor commented Jun 25, 2023

Building static lib with newer compiler version e.g. <2015 is broken due to unitialize variable error.

@arkup Hi, do you mean it's broken in Visual Studio 2015 and later versions?

@arkup
Copy link
Contributor Author

arkup commented Jun 25, 2023

Building static lib with newer compiler version e.g. <2015 is broken due to unitialize variable error.

@arkup Hi, do you mean it's broken in Visual Studio 2015 and later versions?

Hi, yes, because the 'newer' compiler is more strict, the potential use of an uninitialized variable 'const char *sizeStr' is treated as an error.

I only needed to build capstone_static and capstone_dll, but there seem to be more build issues with msvc capstone.sln. In the past, I could open and build all projects included in capstone.sln, but it is no longer possible. I believe cstool.vcxproj is broken and needs adjustments too

@kabeor
Copy link
Member

kabeor commented Jun 25, 2023

Get you. Thanks a lot. Merged.

@kabeor kabeor merged commit 9a4cd0d into capstone-engine:next Jun 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants