Make helper functions static to prevent multiple defintions. #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
approved these changes
Feb 6, 2024
XVilka
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
@kabeor @aquynh please merge this one, it's very important.
The failure is unrelated:
Run pipx run --python "C:\hostedtoolcache\windows\Python\3.11.7\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.14.1" cibuildwheel "bindings/python" --output-dir '"wheelhouse"' --config-file '""' --only '""'
creating virtual environment...
determining package name from 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.14.1'...
creating virtual environment...
installing cibuildwheel from spec 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.14.1'...
Invalid --only='""', must be a build selector with a known platform
|
6a55ef3 should fix the CI, please push a commit to trigger it. |
|
@kabeor it's green, please merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for example: rizinorg/rizin#4183