fix push ethernet corrupts data #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
approved these changes
May 9, 2020
There was a problem hiding this comment.
minor comment. currently, curl to codecov will fail until we get the fix in @94.
| /// mbuf.write_data(offset, &EthernetHeader::default())?; | ||
| /// ``` | ||
| #[capsule::test] | ||
| fn bug_push_ethernet_corrupts_buffer() { |
There was a problem hiding this comment.
@drunkirishcoder really want to go w/ this name/comment, and not something more general?
There was a problem hiding this comment.
as discussed, this test is very specific to this piece of bad code. otherwise, the test wouldn't make sense without this additional context. will mark the test with the release version that has the bug and keep the comments.
drunkirishcoder
force-pushed
the
djin/hotfix-ethernet-push
branch
from
9074237
to
647477d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EthernetHeaderis defined as a union. The size of the union is 22 bytes even though a tagless header only needs 14 bytes. On push the buffer is extended by 14 bytes, so the 8-byte overflow will corrupt the data following the extended segment. This fixes the bug by only writing 14 bytes.Type of change
Checklist