Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Replace Image behavior is not clear #48

Closed
steverogers180 opened this issue Aug 31, 2021 · 2 comments
Closed

[Bug] Replace Image behavior is not clear #48

steverogers180 opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@steverogers180
Copy link
Contributor

Screenshot from 2021-08-31 16-03-10

Steps to reproduce this behavior:

  1. Select an image for a new post
  2. Click on Replace Image
  3. Close the image selector window instead of selecting a new image.
@steverogers180
Copy link
Contributor Author

steverogers180 commented Aug 31, 2021

Wrapping file reader and upload logic inside an if block works fine.

handleImage(e): void {
    const image = e.target.files[0]
    if (image) {
        const reader = new FileReader()
        reader.readAsDataURL(image)
        reader.onload = (i) => {
	    if (i.target !== null) {
                this.uploadImage(i.target.result)
            }
        }
    }
}

@nadimkobeissi nadimkobeissi added this to the Demo milestone Sep 1, 2021
@chrispanag chrispanag added the bug Something isn't working label Sep 3, 2021
jackdishman added a commit that referenced this issue Sep 3, 2021
@jackdishman
Copy link
Contributor

Resolved in 579faf8

jackdishman added a commit that referenced this issue Sep 3, 2021
* Fixed long name formatting on profile page

* Issue #62 - tags are not cleared between posts

* Bugfix #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants