feat: add basic document preview and update document schema #120
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
| }, | ||
| }); | ||
| }; | ||
| import { api } from "@/trpc/server"; |
There was a problem hiding this comment.
Quite curious, this is SSR page, why make a trpc call when you can call db directly?
There was a problem hiding this comment.
both does the job . They're colocated into tRPC because when tRPC 11 stabilizes, while calling a tRPC procedure (basically a fetch request) RSC can deduplicate requests while fetching the same data (since next.js monkey patches fetch).
prisma/schema.prisma
Outdated
| type DocumentType | ||
| size Int | ||
| mimeType String | ||
| uploadProvider UploadProviders |
There was a problem hiding this comment.
Do we need to mention providers. My understanding is R2, S3, minio all work with s3 aws-sdk api
| COMPLETED | ||
| } | ||
|
|
||
| model Document { |
There was a problem hiding this comment.
Lets create a Template table to record these templates. Ideally document table will only have completed/signed documents, and these documents are the one we populate on /documents table.
prisma/schema.prisma
Outdated
| } | ||
|
|
||
| model DocumentFields { |
There was a problem hiding this comment.
After creating Template table, this could be named to TemplateField <= singular and the columns could be
- id
- name
- order (this is the order in which it should be filled out, for example if they have firstName, lastName, date, signature, they should be ordered as accordingly firstName first and signature last.)
- position: JSON
eg:{ right: "100px", left: "200px", top: "300px", bottom: "400px" } - type
- placeholder
- required
- templateId
prisma/schema.prisma
Outdated
| SIGNED | ||
| } | ||
|
|
||
| model DocumentRecepients { |
There was a problem hiding this comment.
Let's rename this model to just EsignRecipient <= Singular (ideally all model/table names should be singular). And I think we need following columns
- id
- email (optional), if this is going to be sent to someone else (not part of the company, eg: new employees, advisors, investors before they are onboarded)
- templateId (this is the template they are signing)
- membershipId (and its association)
- verificationToken, (create an association with VerificationToken table as well, this is to make sure the right recipient signs and we can expire them when not signed within given time)
- status (instead of signingStatus)
| @@ -230,21 +234,121 @@ model EquityPlan { | |||
| @@index([companyId]) | |||
| } | |||
|
|
|||
| model Bucket { | |||
There was a problem hiding this comment.
a generic table to hold upload data
No description provided.