feat: add stakeholders #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
dahal
reviewed
Mar 1, 2024
| @@ -158,7 +158,7 @@ model Stakeholder { | |||
| name String | |||
| email String | |||
| institutionName String? | |||
| stakeholder_type StakeholderTypeEnum @default(INDIVIDUAL) | |||
dahal
reviewed
Mar 1, 2024
| href="/sample-csv/opencap-stakeholders-template.csv" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="rounded bg-gray-300/70 px-2 py-1 text-xs font-medium hover:bg-gray-400/50" |
There was a problem hiding this comment.
We prolly need a download attribute
<Link
download
href="/sample-csv/opencap-stakeholders-template.csv"
target="_blank"
...
dahal
reviewed
Mar 1, 2024
| if (uniqueStakeholders.length > 0) { | ||
| await ctx.db.stakeholder.createMany({ | ||
| data: uniqueStakeholders, | ||
| skipDuplicates: true, |
There was a problem hiding this comment.
Do we need to pre-filter if we have skipDuplicates?
There was a problem hiding this comment.
oh yeah, even if I wrote the skipDuplicates: true it was still creating duplicate entries, so I wrote my own filtering.
now that I just released that the email field in the schema should be @unique which wasn't before.
I added a unique constraint in the email field in the schema and now it is working 👍
Thanks !
dahal
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Its looking great @Aashish-Upadhyay-101 , I have left few comments. Please address those and it'll be ready to merge 🚀
dahal
force-pushed
the
feat/add-stakeholders
branch
from
46554d6
to
419c74d
Compare
dahal
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #137