Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add signining document feature #156

Merged
merged 43 commits into from
Mar 5, 2024
Merged

feat: add signining document feature #156

merged 43 commits into from
Mar 5, 2024

Conversation

G3root
Copy link
Collaborator

@G3root G3root commented Feb 27, 2024

No description provided.

@G3root G3root marked this pull request as draft February 27, 2024 10:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@G3root
Copy link
Collaborator Author

G3root commented Feb 28, 2024

@dahal here's the current state of this PR

  • text field are implemented and can be rendered on the uploaded pdf

things to do

  • implement signature field

known issues

  • positioning currently doesn't work as expected for pdf's with uneven page height, the current algorithm need some small tinkering.
Screencast.2024-02-28.22.27.53.webm

@G3root
Copy link
Collaborator Author

G3root commented Feb 28, 2024

Any feedback is appreciated

dahal
dahal requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking great @G3root. Great job 🫡

I assume you are going to fill these input/canvas as well right?

CleanShot 2024-02-28 at 22 38 43

Also, when scrolling document while signing, lets make that right hand side input card fixed/sticky as well

@G3root G3root marked this pull request as ready for review March 3, 2024 18:10
@G3root G3root requested a review from dahal March 3, 2024 18:10
dahal
dahal requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G3root looks like creating a template feature is broken. I could not test the signing without creating the template.

2024-03-03 21 48 44

@G3root G3root requested a review from dahal March 4, 2024 07:23
@G3root
Copy link
Collaborator Author

G3root commented Mar 4, 2024

@dahal now fixed

dahal
dahal approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, more optimization coming soon 😻

@dahal dahal merged commit a77c530 into main Mar 5, 2024
2 checks passed
@dahal dahal deleted the sign-document branch March 5, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahal dahal dahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G3root @dahal