Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the db port number #159

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Mar 1, 2024

Fixes this error-
Screenshot 2024-03-01 183856

Copy link

github-actions bot commented Mar 1, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Collaborator

@G3root G3root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @anikdhabal ❤️. Can we revert to using 54321 for port binding in the docker-compose.yml file for postgres instead of modifying these configurations? It seems that it was changed in one of the recent PR.

@anikdhabal
Copy link
Contributor Author

Good catch, @anikdhabal ❤️. Can we revert to using 54321 for port binding in the docker-compose.yml file for postgres instead of modifying these configurations? It seems that it was changed in one of the recent PR.

Yeah sure. Thanks for the review.

@G3root G3root self-requested a review March 2, 2024 04:32
Copy link
Collaborator

@G3root G3root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@dahal dahal merged commit 1f6b928 into captableinc:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants