Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New SAFEs with y-combinator and custom template #219

Merged
merged 23 commits into from
Apr 1, 2024
Merged

feat: New SAFEs with y-combinator and custom template #219

merged 23 commits into from
Apr 1, 2024

Conversation

Raju-kadel-27
Copy link
Member

@Raju-kadel-27 Raju-kadel-27 commented Mar 25, 2024 •
edited

fixes #178

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@Raju-kadel-27 Raju-kadel-27 changed the title Feat : Create new yc and custom template feat : Create new yc and custom template Mar 25, 2024
@Raju-kadel-27 Raju-kadel-27 changed the title feat : Create new yc and custom template feat: Create new yc and custom template Mar 25, 2024
@Raju-kadel-27 Raju-kadel-27 marked this pull request as ready for review March 25, 2024 18:02
@Raju-kadel-27
Copy link
Member Author

@dahal @chetannn I think it's ready for review ?

dahal
dahal requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are few errors I ran into

  • Build errors with ./procedures/get-safes and ./procedures/delete-safe no defined.
  • Template upload error

image

@Raju-kadel-27 Raju-kadel-27 marked this pull request as draft March 26, 2024 15:41
@Raju-kadel-27 Raju-kadel-27 changed the title feat: Create new yc and custom template feat: New SAFEs with y-combinator and custom template Mar 29, 2024
@Raju-kadel-27
Copy link
Member Author

@dahal I think errors are resolved ?

@Raju-kadel-27 Raju-kadel-27 marked this pull request as ready for review March 29, 2024 13:56
@dahal dahal self-assigned this Apr 1, 2024
dahal
dahal approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dahal dahal merged commit 91b74d3 into captableinc:main Apr 1, 2024
2 checks passed
@Raju-kadel-27 Raju-kadel-27 deleted the feat/create/new/safe branch April 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahal dahal dahal approved these changes

Assignees

@dahal dahal

Labels
PR: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new SAFE with YC template and custom template
2 participants
@Raju-kadel-27 @dahal