Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: email and password login feature #260

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Apr 20, 2024

fixes #204

  1. Add credentials provider
  2. Verify Email upon new registration
  3. Ability to forgot password

Copy link

github-actions bot commented Apr 20, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@anikdhabal anikdhabal marked this pull request as draft April 20, 2024 01:11
@anikdhabal anikdhabal marked this pull request as ready for review April 20, 2024 15:21
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anikdhabal
Copy link
Contributor Author

We have a build error, details on this thread https://discord.com/channels/1193628549756747776/1203029858385399878/1231472102633377863

Thanks for the review. I will fix that quickly.

@anikdhabal anikdhabal requested a review from dahal April 21, 2024 09:11
@G3root
Copy link
Collaborator

G3root commented Apr 26, 2024

I believe we need to update the flow for inviting users as we switch to a credential provider. The current invite flow is based on a magic link provider, so passwords might not be included in it. 🤔

@dahal
Copy link
Contributor

dahal commented Apr 26, 2024

I believe we need to update the flow for inviting users as we switch to a credential provider. The current invite flow is based on a magic link provider, so passwords might not be included in it. 🤔

I think we can utilize password reset flow for invitation as well. @anikdhabal lets create a different issue for this.

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this PR @anikdhabal . I have created few issues to improve/fix some flows.

#269 & #270

Merging this for now, so above issues are unblocked.

@dahal dahal merged commit 371dbf2 into captableinc:main Apr 26, 2024
2 checks passed
@anikdhabal
Copy link
Contributor Author

Thanks @dahal @G3root for the review. Yes, we need to update the flow. I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement email/password login and remove magic link
3 participants